Set a default gzip compression level globally #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I forgot to mention, but this started as a refactor because I think the |
marcelm
reviewed
Jan 15, 2024
I set a default threads at one point, but had to conclude that this changed the logic and changed it back. Also the reason to choose level 1 by default is that currently python-isal is chosen for compression when it is available. Setting it to 5 or 6 would change this behavior. So I think the logic is still equivalent, except that level 1 is chosen rather than level 2 (python-isal default) but that is OK (and more consistent). |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the previous setup where the default was determined by the backend.
I set the default to 1 for now. Most people will have python-isal installed, and this would have been the default for
None-level compression for most users. I prefer promoting python-isal anywhere possible and as xopen states on the README that it chooses the most efficient way possible a level of 1 seems appropriate.I am also open to setting it to 5, however. I don't think it is that important. As most upstream applications have their own preferred default anyway.